Fix the skipped test in dotnet #238
Open
+115
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a previously skipped test Can_Return_Binary_Result in the .NET SDK by adding the necessary JSON serialization support and creating the corresponding test snapshot file.
Changes:
- Added
ToolResultAIContenttype to the JSON serialization context to properly serialize binary tool results - Unskipped the test and added
serializerOptionsparameter toAIFunctionFactory.Create - Created snapshot file
can_return_binary_result.yamlwith expected conversation flow for binary result testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/snapshots/tools/can_return_binary_result.yaml | Adds test snapshot defining expected conversation flow for binary image result, showing both intermediate and complete states |
| dotnet/test/ToolsTests.cs | Unskips test, adds ToolResultAIContent to JSON context, provides serializerOptions to AIFunctionFactory, and changes assertion method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
Can_Return_Binary_Resultwas skipped. Made the necessary changes to correct it and unskipped it.